Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unindent main block #654

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Unindent main block #654

merged 3 commits into from
Jan 4, 2025

Conversation

hdwalters
Copy link
Contributor

Fixes #648.

@hdwalters hdwalters requested review from Ph0enixKM and mks-h December 30, 2024 14:46
@hdwalters hdwalters changed the base branch from main to staging December 30, 2024 14:48
@hdwalters hdwalters self-assigned this Dec 30, 2024
@mks-h mks-h removed their request for review December 30, 2024 15:18
@hdwalters hdwalters requested a review from Mte90 December 31, 2024 13:18
@Ph0enixKM
Copy link
Member

This is a good temporary solution. When I get my hands dirty with Translation Modules, then this code will be rewritten as something like:

return block.render_no_indent()

@Ph0enixKM Ph0enixKM merged commit 665cdc1 into amber-lang:staging Jan 4, 2025
1 check passed
@hdwalters hdwalters deleted the unindent-main-block branch January 4, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ph0enixKM Ph0enixKM Ph0enixKM approved these changes

@Mte90 Mte90 Mte90 approved these changes

Assignees

@hdwalters hdwalters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Contents of main block are incorrectly indented
3 participants
@hdwalters @Ph0enixKM @Mte90